Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #983. blur 0.0 panic #1362

Merged
merged 1 commit into from Nov 16, 2020
Merged

Fixes #983. blur 0.0 panic #1362

merged 1 commit into from Nov 16, 2020

Conversation

Mike-Neto
Copy link
Contributor

Fixes #983

Adds a test with the reproduction steps provided in the issue.

@HeroicKatora HeroicKatora merged commit 28ac73e into image-rs:master Nov 16, 2020
Copy link
Contributor

@fintelia fintelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really isn't clear to me why we don't return an error when sigma is negative, but at least this way we're consistent

@HeroicKatora
Copy link
Member

@fintelia Due to the return type not being a result. Unfortunate. But I'd rather consider a fallible newtype around the sigma parameter than erroring in the actual blurring step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when call blur with sigma == 0.0
3 participants