Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct user to DynamicImage for converting #1253

Merged

Conversation

robyoung
Copy link
Contributor

@robyoung robyoung commented Jun 5, 2020

Attempts to address the documentation suggestion in #1252

A lot of the methods for modifying an image are found in the ImageBuffer so that is where I was looking when trying to convert an image to a different Pixel type.

I license past and future contributions under the dual MIT/Apache-2.0 license,
allowing licensees to chose either at their option.

Copy link
Member

@HeroicKatora HeroicKatora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you include the proposed code as short example? That would make it very clear what use DynamicImage means.

Attempts to address the documentation suggestion in image-rs#1252

A lot of the methods for modifying an image are found in the ImageBuffer
so that is where I was looking when trying to convert an image to a
different Pixel type.
@robyoung robyoung force-pushed the issue-1252-add-doc-to-ImageBuffer branch from 2fb8156 to 1face8f Compare June 5, 2020 19:20
@robyoung
Copy link
Contributor Author

robyoung commented Jun 5, 2020

How does that look?

@HeroicKatora
Copy link
Member

How does that look?

Yes, quite good.

@HeroicKatora HeroicKatora merged commit c38ee98 into image-rs:master Jun 5, 2020
@HeroicKatora
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants