Promotes next to master branch #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is an open question whether L2 and L4 should be included, or conversely whether L1 should be eliminated
Also clarify description of ColorType::Unknown and fix a few warnings
Refactor the ColorType enum
Continue refactoring ColorType
A bunch more ColorType improvements for image:next
Make copy_from return an ImageResult instead of a boolean
Update next with latest changes to master
Unlike the other formats this is not a single acronym, doesn't contain too many capitals and the website and documentation strongly suggests this way.
Convert ImageFormat variants to CamelCase
Proper capitalization for decoder struct names
Add missing feature requirement dxt for dds
Moves away from a single, open representation of errors. This considers a previously identified few issues: * The new variants are somewhat actionable since they at least identify the cause more closely. * They are extensible as most state is opaque to some degree and key enumerations are marked as non-exhaustive. * They are more precise as the opaque state allows storing specialized variants for supported formats while still maintaining a uniform interface and permitting extension formats outside the library. * Handling of 'stringification' is more principled as error values can be stored as-is instead of converting them on the spot. This might also improve the performance when the conversion is not required. This is part of a patch series. The commit merely adds the new type and a rough interface but does not yet convert the existing error instances and return types.
Emulates the old enum variants with the new type through constructor methods. Note that some variants have been slightly abused and do not map cleanly to a single new kind. These should be adjusted over time. The constructors are private to the crate. While exposing them would help transition, this also allows us to selectively and incrementally rework our own error usage by deprecating them and fixing occurring warnings. In particular, we should expose underlying errors as causes and so on. This commit is part of a patch series reworking error types. The next patch switches the old error type for the new one.
* The format detection is switch to clean variants * The pnm decoder was the only to utilize NotEnoughData and has been switched to a generic format error. It should not be an IO error. * The external test matches on the renamed unsupported variant
Note that these are structural and thus also asserted on the interior subtypes. (Unless an unsafe impl were to be added but that should never happen in any case.)
All `new` constructors accept a detailed underlying description while the shorthands and alternatives are renamed to `from_*_hint` and `from_kind` respectively. This is supposed to encourage utilizing a detailed error representation in dependencies with the new constructor. Note that the UnsupportedError and LimitError have no `new` constructor but utilize the naming convention regardless. This is to avoid blocking the name if we introduce an underlying error representation for them.
These are not modified while storing within the error and should be faded out over time. Storing the Box<str> saves some space in the representation with the size of a pointer. Note that DecodingError is actually the largest struct right now due to it supporting some legacy representations.
Fix benchmarks to edition 2018
Error rework
Hide some public interface dependencies on gif and jpeg. Note that frame oriented functions are now unused and will likely be brought back in a (slightly less generic) manner that is more uniform over other multi frame formats as well.
Note that some use within the library itself would use a buffer with wrong buffer size or disregard width and height errors.
Interface restrictions for gif and jpeg
See the nightly feature `public-dependency`, tracking issue: #44663
Add travis script and public dependency reference
Two major reasons: * This avoids the public dependency on `num_ratio`. * The internal representation can be changed. This already proved necessary once (from u16 rational) and in this manner we are free to do it again by adding an inner enum representation. Note that we already have rounding semantics for the meaning of Delay as gif rounds to the nearest 10ms when writing frames. Any more or less precise representation can be made to round to the closest u32 ratio.
With the original available as a millisecond ratio this can easily be done to the accuracy of nanoseconds, which is the finest available.
Given the prior usage, it does not make much sense to provide an exact conversion. However, it should be clear that precision is not finite and the representation is not exactly that of a Duration. The implementation turned out to be fairly involved as the num-fraction crate does not provide approximation algorithms for fractions. No fear, we code them ourselves with extensive testing to cover much more than the required accuracy tests.
Encapsulate the delay ratio
Upstream from master
|
Travis network failures are far from spurious, it's getting somewhat annoying.. This was the third time or so I had to manually restart a failing task due to it in the last week.. |
|
Does anywhere in this merge include a |
|
I didn't do any. Yes, seems like a good idea to do one. Especially seeing if we can configure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this, a release PR for
0.23will be done and the old version will get aversion-0.22branch (in case we have to do any safety critical bug fixes).