Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for 0.8 #187

Merged
merged 2 commits into from Nov 10, 2022
Merged

Changelog for 0.8 #187

merged 2 commits into from Nov 10, 2022

Conversation

HeroicKatora
Copy link
Member

No description provided.

@fintelia
Copy link
Contributor

fintelia commented Nov 5, 2022

If we're going to make a major release, we should probably take the chance to remove the deprecated methods on tiff::decoder::Decoder and check whether there's any other breaking changes worth making

@HeroicKatora
Copy link
Member Author

What about the methods related to read_chunk that require the caller to track current_chunk? Should we already remove those as well or keep them deprecated for a time?

It doesn't seem to critical in that they don't block any effort for writing a decomposed abstraction. However, since we currently don't have it yet, it feels wrong to fully remove them outright.

@fintelia
Copy link
Contributor

fintelia commented Nov 5, 2022

I just created #188. It turns out that current_chunk doesn't actually get used anymore, so I think that solves your concern?

Copy link
Contributor

@fintelia fintelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth unifying Decoder::strip_count and Decoder::tile_count while we have the chance, but otherwise looks good to me

@HeroicKatora HeroicKatora merged commit 9333d99 into master Nov 10, 2022
@HeroicKatora HeroicKatora deleted the release-0.8.0 branch November 10, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants