Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom functions are not running for values from files #75

Open
amirylm opened this issue May 23, 2021 · 3 comments
Open

Custom functions are not running for values from files #75

amirylm opened this issue May 23, 2021 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@amirylm
Copy link

amirylm commented May 23, 2021

I've noticed that when reading a config file with a field that is not available in env, its custom function won't run.

The reason seems to be that for these kind of fields, parseValue won't be called and therefore the corresponding custom function.

Custom functions runs only if the field was provided as an env argument or with a zero'ed value:

@ilyakaznacheev ilyakaznacheev added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Jul 22, 2021
@ilyakaznacheev
Copy link
Owner

Thanks, marked to be fixed.

Feel free to send a PR with a fix if you have ideas on how to fix that! I had huge issues with free time last months, so not sure when I will fix that by myself.

@pansachin
Copy link
Contributor

👋🏻 @ilyakaznacheev I would love to take a look at this. Could you assign this to me? Thanks!

@ilyakaznacheev
Copy link
Owner

@pansachin sure, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants