Add tomli test case for different python versions #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenetriguba
force-pushed
the
test/tomli-install
branch
from
d8eed94
to
5fc1079
Compare
illBeRoy
approved these changes
Mar 2, 2022
|
@illBeRoy Should this change be released? |
|
Done :) released as 1.10.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test case for the tomli install for #46. Since we're already running these tests on CI on a number of various python versions that are supported, this adds a test case along side those to make sure that the test case for Python 3.6 has the tomli v1 version installed when it runs and 3.7+ has the v2 version installed.
Let me know if this works! We would probably want to merge in #46 first, rebase this branch to pull in those changes, and then merge in this test case? I had to copy-paste the change from that PR here so I could actually run the test case and have it pass.