Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PEP 604 unions, types.UnionType #83

Merged
merged 1 commit into from Jun 2, 2022
Merged

Support PEP 604 unions, types.UnionType #83

merged 1 commit into from Jun 2, 2022

Conversation

antonagestam
Copy link
Contributor

@antonagestam antonagestam commented Nov 28, 2021 •
edited

Hi 馃憢

This PR adds support for PEP 604 unions, that is unions that yield a types.UnionType object.

@antonagestam antonagestam marked this pull request as ready for review November 28, 2021 18:42
@ermakov-oleg
Copy link

Hi!
@ilevkivskyi Are there any plans to support PEP 604?
Is there anything stopping us from adding it?

@pschanely pschanely mentioned this pull request Apr 7, 2022
Closed
ilevkivskyi
ilevkivskyi approved these changes Jun 2, 2022
View reviewed changes
Copy link
Owner

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and sorry for delay!

@ilevkivskyi ilevkivskyi merged commit c6adf81 into ilevkivskyi:master Jun 2, 2022
@antonagestam antonagestam deleted the feature/pep-604-unions branch June 2, 2022 11:57
@antonagestam
Copy link
Contributor Author

No worries, thanks for merging! 馃コ

@antonagestam antonagestam mentioned this pull request Jun 7, 2022
Merged
@antonagestam antonagestam mentioned this pull request Dec 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@antonagestam @ermakov-oleg @ilevkivskyi