Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_manifest() helper on Collection drops homepage property when provided #191

Open
markpbaggett opened this issue Oct 6, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@markpbaggett
Copy link

Expected behaviour:

In order to use iiif-prezi3 to easily iterate over a list of manifests and create a new Collection manifest, I'd like to use the make_manifest() helper. Doing something simple like this should allow me to create a list of manifests with an id, label, homepage, and thumbnail.

        for document in self.iiif_works:
            collection.make_manifest(
                id=document['manifest'],
                label={'en': document['sourceResource']['title']},
                homepage=[{
                    'id': document['isShownAt'],
                    'label': {'en': document['sourceResource']['title']},
                    'type': 'Text',
                    "language": ["en"],
                    "format": "text/html"}],
                thumbnail={
                    'id': document['object'].replace('http://', 'https://'),
                    "type": "Image",
                    "format": "image/jpeg"
                }
            )

Observed behaviour:

Unfortunately, when using this helper method, the homepage property is always dropped from the resulting Collection.

Potential bug location(s):

Any other comments:

A thread about this was brought up a few days ago here:
https://iiif.slack.com/archives/C04EWD70FCH/p1696253869888859

@markpbaggett markpbaggett added the bug Something isn't working label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant