Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest items property is optional #122

Open
digitaldogsbody opened this issue Dec 2, 2022 · 0 comments · May be fixed by IIIF/presentation-validator#157
Open

Manifest items property is optional #122

digitaldogsbody opened this issue Dec 2, 2022 · 0 comments · May be fixed by IIIF/presentation-validator#157
Assignees
Labels
bug Something isn't working iiif-schema upstream Issues caused by problems with upstream libraries

Comments

@digitaldogsbody
Copy link
Member

Expected behaviour:

A Manifest object should not validate if missing the items property - per https://iiif.io/api/presentation/3.0/#34-structural-properties

A Manifest must have the items property with at least one item. Each item must be a Canvas.

Observed behaviour:

You can create a Manifest object without items and Pydantic will not complain

Potential bug location(s):

https://github.com/iiif-prezi/iiif-prezi3/blob/main/iiif_prezi3/skeleton.py#L239

Any other comments:

This is probably a downstream issue from the Validator's JSON Schema. We can temporarily fix it by adding the AutoItems helper to the Manifest class although this only makes sure items is present, not that it has any content.

@digitaldogsbody digitaldogsbody added bug Something isn't working upstream Issues caused by problems with upstream libraries labels Dec 2, 2022
@glenrobson glenrobson self-assigned this Dec 2, 2022
@glenrobson glenrobson linked a pull request Dec 9, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working iiif-schema upstream Issues caused by problems with upstream libraries
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants