Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I noticed that
$ bundle install
is no longer working because a Rake method that is being called by rspec-core was renamed fromlast_comment
tolast_method
.The pinned version of rpsec, 2.12.0 continues to call
Rake.application.last_comment
, which was renamed toRake.application.last_description
, in the version of Rake that we're pulling.See: rspec/rspec-core@8e723fc for the commit that introduces the change, which was part of rspec 3.5.0.
After pinning rspec to 3.5.0 there was also one test error when running rake:
The tweak in the test case included in the PR fixes it. I tested this on ruby 2.2 and 2.4: