Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing incorrect exports field on package.json #155

Closed
tornadocontrib opened this issue Apr 15, 2024 · 5 comments
Closed

Fixing incorrect exports field on package.json #155

tornadocontrib opened this issue Apr 15, 2024 · 5 comments

Comments

@tornadocontrib
Copy link

I have encountered an error while bundling circomlibjs which depends on ffjavascript exports using rollup.js

rollup/plugins#1705

Seems like either ffjavascript has an incorrect exports field defined or the rollup.js couldn't resolve ffjavascript's export definition correctly.

@tornadocontrib tornadocontrib changed the title Fixing incorrect exports Fixing incorrect exports field on package.json Apr 15, 2024
@Kolezhniuk
Copy link
Contributor

@tornadocontrib Hello!
Could you provide more info about that?
We a using exports field on package json to separate builds for NodeJS and Browser
Also we using rollup with other projects which have ffjavascript as dependency
As an example, see

@tornadocontrib
Copy link
Author

@Kolezhniuk I believe it is because it uses export when the target is nodejs. The examples only use rollup for browser builds.

@Kolezhniuk
Copy link
Contributor

@tornadocontrib One question, why do you need to use rollup for NodeJS?

@tornadocontrib
Copy link
Author

tornadocontrib commented Apr 15, 2024

@Kolezhniuk Because I would like to bundle the dependency to use it offline without doing yarn install, and to preserve the bundled output with Single executable applications https://nodejs.org/api/single-executable-applications.html

@tornadocontrib
Copy link
Author

Fixed by using an older version of ffjavascript though, maybe rollup.js only recognizes old style exports field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants