Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/Improvement: Drawing a element on top of an existing element that does not have a content property. #60

Open
JoshWobbles opened this issue Jun 29, 2019 · 6 comments

Comments

@JoshWobbles
Copy link

The standard way VS handles drawing a new element on top of something that doesn't have a content property, say like a image on top of an image, is that vs will craw up the hierarchy until it finds a element that does and add it to that.

For instance if i have:

grid
|_ Image (stretched to the full size of grid)

and i try to draw a new element it wont let me, I have to draw it elsewhere then drag it in, when in reality it should attach it to the grid.

@jogibear9988
Copy link
Member

Does VS Designer walk down the VisualTree to find the Parent Element, or does it walk down on the Coordinates to find the parent container on that Coordinates.

For Example you have a Canvas with a Full Size Grid and a Full Sizte Image in it, the Image is second in Canvas. So does VS Find the Grid or the Canvas as a Container?

@jogibear9988
Copy link
Member

Don't know when I have time to work on this, if you would do it yourself, the Code for this is in "CreateComponentTool"

@jogibear9988
Copy link
Member

It would be could if we could support both modes, to add to parent container or below visual on coordinates. I also wanted to add both modes for clicking on element and find next one when "Alt" is pressed, but I've not yet had time to work on this too

@JoshWobbles
Copy link
Author

I'm guessing it crawls up the tree until it finds a parent that implements IAddChild, at least that would be the easiest most bullet proof way.

@jogibear9988
Copy link
Member

jogibear9988 commented Jun 30, 2019

i think both would work. do that, or do the hittestway

@JoshWobbles
Copy link
Author

Wish I had that kinda time, i'd love to play with this project, but alas I already have more stuff on my plate than my current allotment of coffee will allow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants