Fix unstable tests and switch to dotcover #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this prevents the code coverage from varying depending on how well the random data compresses
piksel
force-pushed
the
test/dotcover
branch
4 times, most recently
from
7debd7e
to
0fe434b
Compare
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
==========================================
+ Coverage 71.89% 73.30% +1.40%
==========================================
Files 62 68 +6
Lines 7667 8311 +644
==========================================
+ Hits 5512 6092 +580
- Misses 2155 2219 +64
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the code coverage to fluctuate depending on the compressibility of the random data.
It also replaces the
opencover+coverlet.collectormethod withdotcover.The testing and code coverage for windows was split to another job instead of bundling it together with macos/linux with a lot of conditional steps.
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.