SharpZipLib v1.4 introduced breaking change #839
Comments
Bykiev
added a commit
to Bykiev/SharpZipLib
that referenced
this issue
Aug 3, 2023
This PR fixes icsharpcode#839
piksel
pushed a commit
that referenced
this issue
Aug 4, 2023
* Fix ZipFile constructor breaking change This PR fixes #839 * Fix another constructor too * Do not change formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
ZipFile class constructor prior v1.4 had this constructor:
public ZipFile(string name)In v1.4 optional parameter
StringCodecwas added which causingMethod not foundexception in other libraries built with older versions of SharpZipLib. It's a breaking change, instead of adding optional parameter you should create 2 separate constructors.Updating SharpZipLib to v1.4 breaks NPOI: nissl-lab/npoi#1149
Reproduction Code
No response
Steps to reproduce
described
Expected behavior
No breaking change should be introduced
Operating System
Windows, macOS, Linux
Framework Version
.NET 7, .NET 6, .NET 5, .NET Core v3 and earlier, .NET Framework 4.x
Tags
ZIP
Additional context
No response
The text was updated successfully, but these errors were encountered: