Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tar): read full extended headers #675

Merged
merged 2 commits into from Aug 14, 2022
Merged

fix(tar): read full extended headers #675

merged 2 commits into from Aug 14, 2022

Conversation

piksel
Copy link
Member

@piksel piksel commented Oct 10, 2021

Fixes #383, but is not the most elegant solution. TarExtendedHeaderReader should probably be rewritten from scratch.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@codecov
Copy link

codecov bot commented Oct 10, 2021

Codecov Report

Merging #675 (218b219) into master (e1e1a91) will increase coverage by 0.30%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
+ Coverage   73.82%   74.13%   +0.30%     
==========================================
  Files          69       71       +2     
  Lines        8291     8450     +159     
==========================================
+ Hits         6121     6264     +143     
- Misses       2170     2186      +16     
Impacted Files Coverage Δ
...arpCode.SharpZipLib/Tar/TarExtendedHeaderReader.cs 100.00% <100.00%> (ø)
src/ICSharpCode.SharpZipLib/Zip/ZipStrings.cs 48.83% <0.00%> (-20.40%) ⬇️
src/ICSharpCode.SharpZipLib/Tar/TarEntry.cs 67.79% <0.00%> (-1.50%) ⬇️
src/ICSharpCode.SharpZipLib/Zip/ZipFile.cs 77.24% <0.00%> (-0.08%) ⬇️
src/ICSharpCode.SharpZipLib/Zip/ZipEntry.cs 90.90% <0.00%> (ø)
src/ICSharpCode.SharpZipLib/Zip/ZipFormat.cs 89.54% <0.00%> (ø)
...harpCode.SharpZipLib/Encryption/ZipAESTransform.cs 89.09% <0.00%> (ø)
...rc/ICSharpCode.SharpZipLib/Core/ExactMemoryPool.cs 75.00% <0.00%> (ø)
.../ICSharpCode.SharpZipLib/Core/StringBuilderPool.cs 100.00% <0.00%> (ø)
src/ICSharpCode.SharpZipLib/Zip/ZipOutputStream.cs 87.82% <0.00%> (+0.06%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@piksel piksel added this to the v1.4 milestone Oct 10, 2021
@piksel piksel merged commit 7411f3a into master Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Item with the same key has already been added" extracting tar with duplicate headers
1 participant