Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GZipOutputStream.Password doesn't work #590

Closed
proy27 opened this issue Mar 3, 2021 · 3 comments
Closed

GZipOutputStream.Password doesn't work #590

proy27 opened this issue Mar 3, 2021 · 3 comments

Comments

@proy27
Copy link

proy27 commented Mar 3, 2021

Steps to reproduce

Expected behavior

GZipOutputStream.Password doesn't work

Actual behavior

Tell us what happens instead

Version of SharpZipLib

1.3.1

Obtained from (only keep the relevant lines)

  • Package installed using NuGet
@piksel
Copy link
Member

piksel commented Mar 3, 2021 •
edited

Please fill out the issue template. You are currently claiming that you don't expect it to work (whatever that means).

The GZip format does not support encryption, so I am not even sure what you are trying to do...

@Numpsy
Copy link
Contributor

Numpsy commented Mar 4, 2021

It does seem a bit unfortunate that DeflaterOutputStream has a public Password property, given that the encryption it refers to only actually applies to zip files (and the doc comments on the property don't say anything to that effect, so that might be misleading?)

@Numpsy Numpsy mentioned this issue Mar 14, 2021
Merged
@Numpsy
Copy link
Contributor

Numpsy commented Oct 4, 2021

Fixed by #604 ?

@piksel piksel closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@piksel @proy27 @Numpsy