Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AES Support #35

Open
7 of 11 tasks
dgrunwald opened this issue Dec 29, 2013 · 6 comments
Open
7 of 11 tasks

AES Support #35

dgrunwald opened this issue Dec 29, 2013 · 6 comments
Assignees
Labels
encryption enhancement Feature request or other improvements of existing functionality
Milestone

Comments

@dgrunwald
Copy link
Member

dgrunwald commented Dec 29, 2013

SD-1649, originally created on 2/22/2010 08:18:51 by David Pierson

Add 128 and 256 bit AES support compatible with WinZip's
implementation.


Comment from David Pierson on 2/22/2010 08:21:57:
Mostly implemented. Creation via Zipfile and ZipOutputStream, and
extraction via ZipFile is now handled (r499).
Extraction via ZipInputStream is not implemented. FastZip is not
implemented.


Progress:

  • Archive creation:
    • Key sizes:
      • 128 bit
      • 192 bit¹
      • 256 bit
    • API support:
      • Zipfile
      • ZipOutputStream
  • Archive extraction:

¹ Creation of archives with 192-bit key is not supported in any of the leading archiving applications (WinRAR, WinZip, 7-zip, info-zip, Keka).

@McNeight McNeight self-assigned this Apr 14, 2016
@McNeight McNeight modified the milestone: post 1.0 Aug 14, 2016
@piksel piksel added this to To do in Encryption Overhaul Aug 18, 2018
@piksel piksel assigned piksel and unassigned McNeight Aug 24, 2018
@piksel piksel moved this from To do to In progress in Encryption Overhaul Aug 25, 2018
@f00f
Copy link

f00f commented Dec 4, 2019

Are there plans to implement AES support for ZipInputStream? Is there an issue or a PR for it? What's the problem with it?

@Numpsy
Copy link
Contributor

Numpsy commented Dec 4, 2019

Theres a partial implementation in #381, though i hit an issue with auth key handling that I wasn't sure how to fix simply and haven't had chance to look at it recently

@piksel
Copy link
Member

piksel commented Dec 30, 2019

Yes, the "problem" is that ZipInputStream works very differently to ZipFile, so it has to be implemented in another (more complex) way.

@Numpsy
Copy link
Contributor

Numpsy commented Apr 11, 2020

fwiw, I started looking at adding the encryption side pieces to ZipFile ages back and shelved it because I had no time, but i'm looking to get more of that done (#440 is a subset of the required change and tests anyway)

@Numpsy
Copy link
Contributor

Numpsy commented Apr 22, 2020

WIP for creating AES encrypted files with ZipFile in #443

@piksel piksel added this to Preparation in Feature Requests Nov 22, 2020
@piksel piksel moved this from Preparation to In progress in Feature Requests Nov 22, 2020
@remogloor
Copy link

Theres a partial implementation in #381, though i hit an issue with auth key handling that I wasn't sure how to fix simply and haven't had chance to look at it recently

The issue with the auth key is solved in #551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
encryption enhancement Feature request or other improvements of existing functionality
Projects
Encryption Overhaul
  
In progress
Feature Requests
In progress
Development

No branches or pull requests

6 participants