C# -> VB: Add addresssof when passing method group

[gmcfarlane]

Input code

public sub foo(){

  v_.MasterRowGetLevelDefaultView += new DevExpress.XtraGrid.Views.Grid.MasterRowGetLevelDefaultViewEventHandler(this.MasterRowGetLevelDefaultView);
}    

Erroneous output

Public Function foo() As [sub]
    v_.MasterRowGetLevelDefaultView += New DevExpress.XtraGrid.Views.Grid.MasterRowGetLevelDefaultViewEventHandler(Me.MasterRowGetLevelDefaultView)
End Function

Expected output

Public Function foo() As [sub]
    v_.MasterRowGetLevelDefaultView += New DevExpress.XtraGrid.Views.Grid.MasterRowGetLevelDefaultViewEventHandler( addressof Me.MasterRowGetLevelDefaultView)
End Function

simply needs addressof as a parameter to the addHandler method.
love the tool.

Details

• Product in use: e.g. icsharpcode.github.io/CodeConverter / VS extension / both
• Version in use: e.g. 5.6.3 or a commit hash (if it's a 3rd party tool using this library, try one of the above)
• Did you see it working in a previous version, which?
• Any other relevant information to the issue, or your interest in contributing a fix.

[Sympatron]

I agree that AddressOf is missing in this case. But it still won't compile, because += does not work for VB.NET.

[gmcfarlane]

Hey thanks for the reply It turns out that the specific function i was using may have been a function provided by the package. I took a minute to go write you a message, THEN went and tried to compile the code... vb requires this code to add a handler. AddHandler gv_.MasterRowGetLevelDefaultView, AddressOf Me.MasterRowGetLevelDefaultView its easy enough for me to self- correct these lines. More often than not , I let the UI declare the handlers by adding the syntax after the routine's signature. the converter is a great tool. A company i used to work at used telerik tools and i really liked them, found this by accident poking around the site. Whether or not you choose to pursue this minor bug is completely up to you. I wanted to do my small small part by reporting a finding! greg

…

-----Original Message----- From: "Sympatron GmbH" ***@***.***> Sent: Monday, November 6, 2023 5:46am To: "icsharpcode/CodeConverter" ***@***.***> Cc: "gmcfarlane" ***@***.***>, "Author" ***@***.***> Subject: Re: [icsharpcode/CodeConverter] C# -> VB: Add addresssof when passing method group (Issue #1039) I agree that AddressOf is missing in this case. But it still won't compile, because += does not work for VB.NET. — Reply to this email directly, [ view it on GitHub ]( #1039 (comment) ), or [ unsubscribe ]( https://github.com/notifications/unsubscribe-auth/AEUCMDJ2SS7SDUXJGR7W42LYDDE2NAVCNFSM6AAAAAA6V5RLPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJUGY2DIMZZGA ). You are receiving this because you authored the thread.Message ID: ***@***.***>

[GrahamTheCoder]

Thanks both. From the slightly broken input (sub) I assumed the Web converter was used here to convert a quick snippet. It only references a few core dot net libraries, so will never be able to distinguish the thing being assigned here is an event and just makes a best effort.

If you use the extension in visual studio on compiling code, you'll generally get a far better conversion. I'd expect AddHandler to be added
It may also be that addresof is added, or that neither are. Would have to try it.