Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iCloudPD needs to check expiration date before initialization #829

Open
CreativePR opened this issue May 1, 2024 · 1 comment
Open

iCloudPD needs to check expiration date before initialization #829

CreativePR opened this issue May 1, 2024 · 1 comment
Labels

Comments

@CreativePR
Copy link

Overview

Now iCloudPD will try to run regardless if the cookie has expired. If iCloudPD is ran in an automated fashion, this will result in the user receiving multiple verification codes over and over depending if iCloudPD is ran at an automatic interval.

IcloudPD should 1st check the cookie for the expiration date and if it is past thrown an error, do not try to authenticate, and send the email (if so configured)

@CreativePR CreativePR added the bug label May 1, 2024
@AndreyNikiforov
Copy link
Collaborator

What automated fashion are you referring to? --watch-with-interval param? If not, how are you executing icloudpd and it what moment you are getting repeated 2fa codes?

If you are running icloudpd periodically by external scheduler, then I assume each run will be blocked until you enter 2fa code and no subsequent attempts to authenticate will be made. If external scheduling starts another instance of icloudpd while prev is blocked waiting for user input, fixing scheduling is probably an appropriate step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants