Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish source tarball to pypi? #811

Closed
chenrui333 opened this issue Apr 11, 2024 · 14 comments
Closed

publish source tarball to pypi? #811

chenrui333 opened this issue Apr 11, 2024 · 14 comments

Comments

@chenrui333
Copy link

馃憢 can you also publish the source tarball to pypi for package manager to consume? Thanks!

relates to Homebrew/homebrew-core#168596

@AndreyNikiforov
Copy link
Collaborator

Screenshot 2024-04-10 at 6 19 14鈥疨M

It is there (icloudpd-1.17.4-py3-none-any.whl). You mos likely want to use default pip behavior that will download binary if it exists for the platform and fall back to src if needed. We have macos binary in pypi as well (icloudpd-1.17.4-py2.py3-none-macosx_11_0_x86_64.macosx_11_0_arm64.whl)

@chenrui333
Copy link
Author

yeah, those are all wheels, I am looking for the source tarball

image

@AndreyNikiforov
Copy link
Collaborator

I don't think we ever provided src to pypi, only wheels. Src is available in github though:
Screenshot 2024-04-10 at 6 46 51鈥疨M

Looking at the PR for homebrew, it seems that src from github were used before.

Is there any particular reason you want to use src, not binaries? Any reason you want zipped src vs wheels?

@chenrui333
Copy link
Author

Looking at the PR for homebrew, it seems that src from github were used before.

yeah, the problem with github artifact is we dont have any mechanism to populate the dependency list.

@AndreyNikiforov
Copy link
Collaborator

yeah, the problem with github artifact is we dont have any mechanism to populate the dependency list.

Figuring out dependencies is challenging. We had a lot of issues reported related to dependencies until we switched to binary distribution.

BTW the failure in homebrew PR is in test expectation and icloudpd seems to be installed and running fine.

@chenrui333
Copy link
Author

Figuring out dependencies is challenging. We had a lot of issues reported related to dependencies until we switched to binary distribution.

that is interesting, any pointer on that (sounds like requirements list issue?)

@chenrui333
Copy link
Author

BTW the failure in homebrew PR is in test expectation and icloudpd seems to be installed and running fine.

yeah, just updated the test to ship this release.

@chenrui333
Copy link
Author

relates to Homebrew/homebrew-core#172656

@AndreyNikiforov
Copy link
Collaborator

relates to Homebrew/homebrew-core#172656

What is the trigger for HB version bump? Should be github release IMO, and it is not yet available for v1.17.6.

@chenrui333
Copy link
Author

What is the trigger for HB version bump?

there is autobump process that we are using.

@chenrui333
Copy link
Author

same deal as this one, Homebrew/homebrew-core#172797

@AndreyNikiforov
Copy link
Collaborator

same deal as this one, Homebrew/homebrew-core#172797

What is the problem with this one? Seems to merged already.

@AndreyNikiforov
Copy link
Collaborator

AndreyNikiforov commented May 25, 2024

What is the trigger for HB version bump?

there is autobump process that we are using.

I suspect that autobump checks repository for changes and pulls sources from GH release. It takes hr+ to build and publish icloudpd, so to avoid problems in future, it would be best for you to adjust autobump process to use GH releases instead of source code changes (for checks and for pulling sources).

@AndreyNikiforov
Copy link
Collaborator

closing as the issue is related to how homebrew detects changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants