Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images not getting deleted in Shared LIbrary with delete_after_download=true #802

Closed
b00llean opened this issue Mar 12, 2024 · 6 comments
Closed
Labels

Comments

@b00llean
Copy link

Overview

Images are not getting deleted when Shared Library is used and delete_after_download is set to true.

Steps to Reproduce

  1. Supply delete_after_download=true command line optio, auto_delete=false, photo_library=SharedSync-CA6C4E18-xxxxxxxx
  2. Observe debug messages in logfile . Example:

2024-03-11 22:25:13 INFO Deleted IMG_2225.HEIC in iCloud

  1. Observe downloaded (and per log messaged deleted) mages remain in "Shared Library" in iCloud on all devices. Verified via web access to iCloud. Nothing gets deleted automatically.

Expected Behavior

Downloaded images are expected to disappear from "Shared Library"

Actual Behavior

Downloaded images remain visible in "Shared Library". If deleted locally, icloudpd re-downloads them from "Shared Library"

Context

I tried latest version of icloudpd to run on native os paython and within docker - same behavior.

@b00llean b00llean added the bug label Mar 12, 2024
@AndreyNikiforov
Copy link
Collaborator

What version of icloudpd are you using, how are you getting it (docker, binary etc; what location, image name), what parameters are you using? The parameters you provided suggested that you may be using images from other projects. If you give full cmd line with minimum set of params reproducing the issue, it may give others better idea how to help too.

Re "Shared libs": I don't use it myself and saw reports in GH suggesting that SL may have some unexpected behavior.

@b00llean
Copy link
Author

Sure,

Here is the command line that is being used in docker version and what I've tried to use in command line in "bare" install:
icloudpd --directory /photo_archive --cookie-directory /config --domain com --username xxxxxxx@icloud.com --no-progress-bar --delete-after-download --skip-videos --folder-structure SharedSync-xxxxxxxxxxx/{:%Y/%Y-%m/%Y-%m-%d} --library SharedSync-xxxxxxxxxxxx

@AndreyNikiforov
Copy link
Collaborator

From what I can tell current code supports deleting from PrimarySync only

@b00llean
Copy link
Author

Evidently so.

Should this be a bug or an RFE?

@AndreyNikiforov
Copy link
Collaborator

It has never been implemented, so RFE seems better suited.

@AndreyNikiforov
Copy link
Collaborator

fixed in 1.17.7. reopen if issue persists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants