CRLF in source files - Configuration Standard? #744
Replies: 2 comments 1 reply
-
Ugh, my bad, I did not notice CRLF change for the photos.py file. I develop on Windows in linux container with Git client on Windows itself; and on codespaces (==linux container as well). Suspect that my Windows git client added CRLF to photos.py, need to experiment... So far in icloudpd project I found scripts for unix to be the most sensitive for line-ending, not the python source code. Since you seems familiar with CRLF management in git more than I do, can you pls outlining a) what is the current state of CRLF for the project, b) what kind of issues we are facing or may face, c) what are resolution options with pro/cons, and d) your recommendation? |
Beta Was this translation helpful? Give feedback.
-
@AndreyNikiforov - I'm noticing some changes showing up with inconsistent CRLF. The latest commit in master for example showed the entire
pyicloud/services/photos.py
file being changed, even through there were only two lines. I can hide this when comparing easily enough withgit diff -w
of course.I'm using Linux for developing and I imagine others may be using Windows or MacOS in some cases. Should there be a .gitattributes to help maintain the correct CRLF settings (to whatever is appropriate) for the repository in case the local
core.autocrlf
settings may vary between contributors?Is there a recommended CRLF standard we should adhere to, or is it not really that important and can be ignored (using
git diff -w
when needed)?Beta Was this translation helpful? Give feedback.
All reactions