fix: check if URL with replaced defaultLocale in notFoundRoutes #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently replace the defaultLocale (when i18n is enabled) in the urlSet (with the help of a regex), but URLs in notFoundRoutes are not replaced. This would cause notFound routes on the defaultLocale to be missed when filtering. Add additional check to check if url with edfaultLocale replacedd is included in notFoundRoutes
iamvishnusankar
approved these changes
Sep 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Suppose there is a route
/only-nl, that only exists in a particular locale,nl-NL. Currently, when generating the sitemap, we will see both the followinglocin the sitemap:This^ is wrong, since the route only exists in the
nl-NLlocale. Here is the expected output:- /only-nl /nl-NL/only-nlWhy
We currently replace the
defaultLocale(when i18n is enabled) in theurlSet(with the help of a regex), but URLs innotFoundRoutesare not replaced.This would cause "notFound" routes on the
defaultLocale(like/only-NL) to be missed when filtering.What I've done
defaultLocalereplaced is included innotFoundRoutesPlease let me know if there's anything else you'd like me to add here, and feedback if it can be handled in a better way.
Thanks!