Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing peerDep of eslint-config-airbnb #60

Closed
amilajack opened this issue Jan 26, 2020 · 1 comment
Closed

missing peerDep of eslint-config-airbnb #60

amilajack opened this issue Jan 26, 2020 · 1 comment

Comments

@amilajack
Copy link

amilajack commented Jan 26, 2020

eslint-config-airbnb requires a peerDep of eslint-plugin-react-hooks:

warning "eslint-config-airbnb-typescript > eslint-config-airbnb@18.0.1" has incorrect peer dependency "eslint-plugin-re
act-hooks@^1.7.0".

I'd love to submit a PR for this. Would that be welcome?

@iamturns
Copy link
Owner

iamturns commented Feb 8, 2020

Hey @amilajack - absolutely, all PRs welcome!
I think this repo needs to be broken into two separate packages to fix this issue. If so, it's quite a bit of work.
But if you find another way to solve this problem, very happy to discuss and/or review a PR 👍
This issue is reported and tracked in #6, so will close this one.
Cheers!

@iamturns iamturns closed this as completed Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants