Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface peer dependencies of eslint-config-airbnb-base dependency #275

Merged

Conversation

jrolfs
Copy link
Contributor

@jrolfs jrolfs commented Feb 12, 2022

I believe this is ok as a non-breaking change as this package pretty much implicitly requires eslint and eslint-plugin-import, right?

Fixes #274

See also: #207 (comment)

@jrolfs jrolfs changed the title fix: add peer dependencies of eslint-config-airbnb-base Surface peer dependencies of eslint-config-airbnb-base dependency Feb 12, 2022
Copy link
Owner

@iamturns iamturns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jrolfs !

Sorry for the delay, I missed the notification (drowned by Renovate PRs)

A couple of changes requested, what do you think?

README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@jrolfs jrolfs force-pushed the fix/surface-airbnb-peer-dependencies branch from 52e7bd5 to 5aa7b20 Compare March 10, 2022 17:56
@jrolfs
Copy link
Contributor Author

jrolfs commented Mar 10, 2022

No worries on the delay, and thanks for the review — I guess I was moving pretty quickly when I opened this 😬.

@jrolfs jrolfs requested a review from iamturns March 10, 2022 17:58
@jrolfs
Copy link
Contributor Author

jrolfs commented Mar 11, 2022

Oh, and I also just wanna say thanks for creating and maintaining this package!

@iamturns iamturns merged commit b90ce9f into iamturns:master Mar 13, 2022
@iamturns
Copy link
Owner

🎉 This PR is included in version 16.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 18, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [eslint-config-airbnb-typescript](https://github.com/iamturns/eslint-config-airbnb-typescript) | devDependencies | patch | [`16.1.1` -> `16.1.2`](https://renovatebot.com/diffs/npm/eslint-config-airbnb-typescript/16.1.1/16.1.2) |

---

### Release Notes

<details>
<summary>iamturns/eslint-config-airbnb-typescript</summary>

### [`v16.1.2`](https://github.com/iamturns/eslint-config-airbnb-typescript/releases/v16.1.2)

[Compare Source](iamturns/eslint-config-airbnb-typescript@v16.1.1...v16.1.2)

##### Bug Fixes

-   yarn 2 installation errors about peer dependencies fixed ([#&#8203;275](iamturns/eslint-config-airbnb-typescript#275)) ([b90ce9f](iamturns/eslint-config-airbnb-typescript@b90ce9f)), closes [#&#8203;274](iamturns/eslint-config-airbnb-typescript#274)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1219
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package.json doesn't correctly contain all peerDependencies
2 participants