Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package.json doesn't correctly contain all peerDependencies #274

Closed
jereklas opened this issue Feb 7, 2022 · 1 comment · Fixed by #275
Closed

Package.json doesn't correctly contain all peerDependencies #274

jereklas opened this issue Feb 7, 2022 · 1 comment · Fixed by #275
Labels
released

Comments

@jereklas
Copy link

jereklas commented Feb 7, 2022 •
edited

I get the following errors when installing eslint-config-airbnb-typescript via yarn 2.

➤ YN0002: │ eslint-config-airbnb-typescript@npm:16.1.0: doesn't provide eslint (pdeb82), requested by eslint-config-airbnb-base
➤ YN0002: │ eslint-config-airbnb-typescript@npm:16.1.0: doesn't provide eslint-plugin-import (pbb875), requested by eslint-config-airbnb-base

I can resolve this locally with use of the "packageExtensions" feature of yarn 2 as follows:
image

I believe the package.json file needs to be updated to include the "eslint" and "eslint-plugin-import" in the "peerDependencies" section so that installs with yarn 2 do not result in errors.
jrolfs added a commit to jrolfs/eslint-config-airbnb-typescript that referenced this issue Feb 12, 2022
@jrolfs
fix: add peer dependencies of eslint-config-airbnb-base
52e7bd5 
Fixes iamturns#274
@jrolfs jrolfs mentioned this issue Feb 12, 2022
Merged
jrolfs added a commit to jrolfs/eslint-config-airbnb-typescript that referenced this issue Mar 10, 2022
@jrolfs
fix: add peer dependencies of eslint-config-airbnb-base
5aa7b20 
Fixes iamturns#274
iamturns pushed a commit that referenced this issue Mar 13, 2022
@jrolfs
fix: yarn 2 installation errors about peer dependencies fixed (#275)
b90ce9f 
Fixes #274
@iamturns
Copy link
Owner

🎉 This issue has been resolved in version 16.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this issue Mar 18, 2022
Update dependency eslint-config-airbnb-typescript to v16.1.2 (#1219)
3a91c33 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [eslint-config-airbnb-typescript](https://github.com/iamturns/eslint-config-airbnb-typescript) | devDependencies | patch | [`16.1.1` -> `16.1.2`](https://renovatebot.com/diffs/npm/eslint-config-airbnb-typescript/16.1.1/16.1.2) |

---

### Release Notes

<details>
<summary>iamturns/eslint-config-airbnb-typescript</summary>

### [`v16.1.2`](https://github.com/iamturns/eslint-config-airbnb-typescript/releases/v16.1.2)

[Compare Source](iamturns/eslint-config-airbnb-typescript@v16.1.1...v16.1.2)

##### Bug Fixes

-   yarn 2 installation errors about peer dependencies fixed ([#&#8203;275](iamturns/eslint-config-airbnb-typescript#275)) ([b90ce9f](iamturns/eslint-config-airbnb-typescript@b90ce9f)), closes [#&#8203;274](iamturns/eslint-config-airbnb-typescript#274)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1219
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
2 participants
@iamturns @jereklas