Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint@8.x.x has breaking changes #251

Closed
Tracked by #43
jknight12882 opened this issue Oct 11, 2021 · 7 comments · Fixed by #265
Closed
Tracked by #43

eslint@8.x.x has breaking changes #251

jknight12882 opened this issue Oct 11, 2021 · 7 comments · Fixed by #265
Labels

Comments

@jknight12882
Copy link

    TypeError: Failed to load plugin '@typescript-eslint' declared in '.eslintrc.js » eslint-config-airbnb-typescript » /Users/:redacted/Workspace/:redacted/node_modules/eslint-config-airbnb-typescript/lib/shared.js': Class extends value undefined is not a constructor or null
        at Object.<anonymous> (/Users/:redacted/Workspace/:redacted/node_modules/@typescript-eslint/experimental-utils/dist/ts-eslint/CLIEngine.js:12:34)
        at Module._compile (/Users/:redacted/Workspace/:redacted/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)
        at Object.Module._extensions..js (node:internal/modules/cjs/loader:1138:10)
        at Module.load (node:internal/modules/cjs/loader:989:32)
        at Function.Module._load (node:internal/modules/cjs/loader:829:14)
        at Module.require (node:internal/modules/cjs/loader:1013:19)
        at require (/Users/:redacted/Workspace/:redacted/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
        at Object.<anonymous> (/Users/:redacted/Workspace/:redacted/node_modules/@typescript-eslint/experimental-utils/dist/ts-eslint/index.js:14:14)
        at Module._compile (/Users/:redacted/Workspace/:redacted/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)
        at Object.Module._extensions..js (node:internal/modules/cjs/loader:1138:10)
@Zamiell
Copy link
Contributor

Zamiell commented Oct 11, 2021

@iamturns Please also update the deps for typescript-eslint/eslint-plugin and @typescript-eslint/parser, I think that will fix it.

@KristjanTammekivi
Copy link

https://github.com/iamturns/eslint-config-airbnb-typescript/blob/master/package.json#L29 Peerdependencies should be updated

@andrei9669
Copy link

my guess is that we first have to wait for this to be resolved?
airbnb/javascript#2478

@Temez1 Temez1 mentioned this issue Oct 13, 2021
2 tasks
@iamturns
Copy link
Owner

iamturns commented Nov 5, 2021

Peer deps (@typescript-eslint) have been updated to the latest (5.0.0), which will help towards ESLint 8 support.

But as @andrei9669 has pointed out, we need to wait for eslint-config-airbnb-base to support ESLint 8 too, as it's a dependency of this library.

@ModyQyW
Copy link

ModyQyW commented Nov 11, 2021

eslint-config-airbnb@19 and eslint-config-airbnb-base@15 support ESLint 8 now. See airbnb/javascript#2478.

@BohdanYavorskyi
Copy link

Can anybody (🥇) upgrade the eslint-config-airbnb-base in dependecies to 15th version to allow this package to support Eslint 8+?

@iamturns
Copy link
Owner

🎉 This issue has been resolved in version 16.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants