From 11185a9edddd887d4f82c5bdecd94bed8d805230 Mon Sep 17 00:00:00 2001 From: Lucas Vazquez Date: Sat, 19 Mar 2022 19:54:02 -0300 Subject: [PATCH] fix: disable additional rules handled by TypeScript compiler (#283) Rules disabled: `no-import-assign`, `no-setter-return`, `import/no-named-as-default-member` While this could be seen as a breaking change, in reality the TypeScript code would not compile. The code must adhere to these rules already. So the impact of this change is simply reducing unnecessary noise within linting errors (and leaving it to the TypeScript compiler, which is better suited). --- lib/shared.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/shared.js b/lib/shared.js index 08e35b5..0a09793 100644 --- a/lib/shared.js +++ b/lib/shared.js @@ -264,15 +264,18 @@ module.exports = { 'no-dupe-class-members': 'off', 'no-dupe-keys': 'off', 'no-func-assign': 'off', + 'no-import-assign': 'off', 'no-new-symbol': 'off', 'no-obj-calls': 'off', 'no-redeclare': 'off', + 'no-setter-return': 'off', 'no-this-before-super': 'off', 'no-undef': 'off', 'no-unreachable': 'off', 'no-unsafe-negation': 'off', 'valid-typeof': 'off', 'import/named': 'off', + 'import/no-named-as-default-member': 'off', 'import/no-unresolved': 'off', }, },