Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle value setting in dayOfYear call signature #799

Merged
merged 1 commit into from Feb 19, 2020

Conversation

tpict
Copy link
Contributor

@tpict tpict commented Feb 18, 2020

Minor bug fix. The current version doesn't handle the case where the date is being set. Thanks!

@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #799 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #799   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          156       156           
  Lines         1118      1118           
  Branches       207       207           
=========================================
  Hits          1118      1118           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a470fb...ff63215. Read the comment docs.

@iamkun
Copy link
Owner

iamkun commented Feb 19, 2020

THX

@iamkun iamkun merged commit 5809652 into iamkun:dev Feb 19, 2020
iamkun pushed a commit that referenced this pull request Feb 26, 2020
## [1.8.21](v1.8.20...v1.8.21) (2020-02-26)

### Bug Fixes

* Set + Get accept 'D' as the short version of 'date' ([#795](#795)) ([523c038](523c038))
* Update DayOfYear plugin type ([#799](#799)) ([5809652](5809652))
* Update fi (Finnish) locale relativeTime ([#797](#797)) ([4a470fb](4a470fb))
@iamkun
Copy link
Owner

iamkun commented Feb 26, 2020

🎉 This PR is included in version 1.8.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.21](iamkun/dayjs@v1.8.20...v1.8.21) (2020-02-26)

### Bug Fixes

* Set + Get accept 'D' as the short version of 'date' ([#795](iamkun/dayjs#795)) ([523c038](iamkun/dayjs@523c038))
* Update DayOfYear plugin type ([#799](iamkun/dayjs#799)) ([5809652](iamkun/dayjs@5809652))
* Update fi (Finnish) locale relativeTime ([#797](iamkun/dayjs#797)) ([4a470fb](iamkun/dayjs@4a470fb))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.21](iamkun/dayjs@v1.8.20...v1.8.21) (2020-02-26)

### Bug Fixes

* Set + Get accept 'D' as the short version of 'date' ([#795](iamkun/dayjs#795)) ([523c038](iamkun/dayjs@523c038))
* Update DayOfYear plugin type ([#799](iamkun/dayjs#799)) ([5809652](iamkun/dayjs@5809652))
* Update fi (Finnish) locale relativeTime ([#797](iamkun/dayjs#797)) ([4a470fb](iamkun/dayjs@4a470fb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants