Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't get the Days of the Week #779

Closed
faropoulos opened this issue Jan 17, 2020 · 2 comments · Fixed by BlueWallet/BlueWallet#862 or BlueWallet/BlueWallet#961 · May be fixed by mdfaizan7/react-bitConnect-client#4 or cds-snc/apply-for-a-grant#32
Closed

Can't get the Days of the Week #779

faropoulos opened this issue Jan 17, 2020 · 2 comments · Fixed by BlueWallet/BlueWallet#862 or BlueWallet/BlueWallet#961 · May be fixed by mdfaizan7/react-bitConnect-client#4 or cds-snc/apply-for-a-grant#32
Labels
released

Comments

@faropoulos
Copy link

faropoulos commented Jan 17, 2020 •
edited

Describe the bug
I should be able to get all the days of the week with dayjs().weekdays(). Sadly, that function doesn't exist. I even tried the weekday plugin, and still get nothing. Am i missing something;

Below you will find the code

import dayjs from 'dayjs';
import el from 'dayjs/locale/el';

dayjs.locale('el');
dayjs().weekdays();

Expected behavior
I should be able to get an array with the names of the Days of the Week.

Information

  • Day.js Version 1.8.19
  • OS: Mac OS
  • Browser Chrome 79
  • Time zone: Eastern European Time Zone, GMT +3
@iamkun iamkun closed this as completed in 287fed6 Jan 19, 2020
@iamkun
Copy link
Owner

iamkun commented Jan 19, 2020 •
edited

Thanks.
I've update localeData plugin to support this in our coming release.

import localeData from 'dayjs/plugin/localeData'
dayjs.extend(localeData)

//dayjs.locale('en')
dayjs.weekdays()
dayjs.localeData().weekdays()

iamkun added a commit that referenced this issue Jan 19, 2020
@iamkun
fix: Update LocaleData plugin to support dayjs.months dayjs.weekdays API
144c2ae 
fix #779
iamkun pushed a commit that referenced this issue Feb 4, 2020
@semantic-release-bot
chore(release): 1.8.20 [skip ci]
0c385e1 
## [1.8.20](v1.8.19...v1.8.20) (2020-02-04)

### Bug Fixes

* Add Bislama Locale (bi) ([#780](#780)) ([9ac6ab4](9ac6ab4))
* Fix weekOfYear plugin to support yearStart locale for better week number result ([#769](#769)) ([f00db36](f00db36))
* Update et (Estonian) locale relativeTime ([#790](#790)) ([d8e0f45](d8e0f45))
* Update LocaleData plugin to support dayjs.localeData().weekdays() API ([287fed6](287fed6)), closes [#779](#779)
* Update LocaleData plugin to support dayjs.months dayjs.weekdays API ([144c2ae](144c2ae)), closes [#779](#779)
* Update pl locale fusional config ([d372475](d372475))
@iamkun
Copy link
Owner

iamkun commented Feb 4, 2020

🎉 This issue has been resolved in version 1.8.20 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Feb 4, 2020
@snyk-bot snyk-bot mentioned this issue Mar 5, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Mar 22, 2020
Open
This was referenced Apr 8, 2020
Merged
Open
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.20 [skip ci]
fc6acfe 
## [1.8.20](iamkun/dayjs@v1.8.19...v1.8.20) (2020-02-04)

### Bug Fixes

* Add Bislama Locale (bi) ([#780](iamkun/dayjs#780)) ([9ac6ab4](iamkun/dayjs@9ac6ab4))
* Fix weekOfYear plugin to support yearStart locale for better week number result ([#769](iamkun/dayjs#769)) ([f00db36](iamkun/dayjs@f00db36))
* Update et (Estonian) locale relativeTime ([#790](iamkun/dayjs#790)) ([d8e0f45](iamkun/dayjs@d8e0f45))
* Update LocaleData plugin to support dayjs.localeData().weekdays() API ([287fed6](iamkun/dayjs@287fed6)), closes [#779](iamkun/dayjs#779)
* Update LocaleData plugin to support dayjs.months dayjs.weekdays API ([144c2ae](iamkun/dayjs@144c2ae)), closes [#779](iamkun/dayjs#779)
* Update pl locale fusional config ([d372475](iamkun/dayjs@d372475))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.20 [skip ci]
76374fc 
## [1.8.20](iamkun/dayjs@v1.8.19...v1.8.20) (2020-02-04)

### Bug Fixes

* Add Bislama Locale (bi) ([#780](iamkun/dayjs#780)) ([9ac6ab4](iamkun/dayjs@9ac6ab4))
* Fix weekOfYear plugin to support yearStart locale for better week number result ([#769](iamkun/dayjs#769)) ([f00db36](iamkun/dayjs@f00db36))
* Update et (Estonian) locale relativeTime ([#790](iamkun/dayjs#790)) ([d8e0f45](iamkun/dayjs@d8e0f45))
* Update LocaleData plugin to support dayjs.localeData().weekdays() API ([287fed6](iamkun/dayjs@287fed6)), closes [#779](iamkun/dayjs#779)
* Update LocaleData plugin to support dayjs.months dayjs.weekdays API ([144c2ae](iamkun/dayjs@144c2ae)), closes [#779](iamkun/dayjs#779)
* Update pl locale fusional config ([d372475](iamkun/dayjs@d372475))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
2 participants
@iamkun @faropoulos