Fix objectSupport collides with Duration plugin - issue #2027 #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while fixing, an issue wit the handling of subtract appeared and was fixed too.
Codecov Report
@@ Coverage Diff @@
## dev #2038 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 181 181
Lines 2074 2080 +6
Branches 544 547 +3
=========================================
+ Hits 2074 2080 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
THX |
iamkun
pushed a commit
that referenced
this pull request
Oct 21, 2022
|
🎉 This PR is included in version 1.11.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ohsory1324
pushed a commit
to ohsory1324/dayjs
that referenced
this pull request
Dec 20, 2023
## [1.11.6](iamkun/dayjs@v1.11.5...v1.11.6) (2022-10-21) ### Bug Fixes * add BigIntSupport plugin ([iamkun#2087](iamkun#2087)) ([f6dce48](iamkun@f6dce48)) * Fix objectSupport collides with Duration plugin - issue [iamkun#2027](iamkun#2027) ([iamkun#2038](iamkun#2038)) ([c9370ea](iamkun@c9370ea))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the plugins objectSupport and Duration in one file creates false result in .add and .subtract when
extend(Duration)comes beforeextend(objectSupport)- see issue #2027.Fixed this problem and added tests to avoid regression.