Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ordinal for nl not working #2011

Merged
merged 1 commit into from Aug 12, 2022
Merged

fix: ordinal for nl not working #2011

merged 1 commit into from Aug 12, 2022

Conversation

ctessier
Copy link
Contributor

@ctessier ctessier commented Aug 4, 2022 •
edited

In dutch locale, the ordinal doesn't show properly, some letters get interpreted.

Before the fix: ❌

dayjs().locale('nl').format('Do'); // 44e
dayjs('2022-08-23').locale('nl').format('Do'); // 230te

After the fix: ✔️

dayjs().locale('nl').format('Do'); // 4de
dayjs('2022-08-23').locale('nl').format('Do'); // 23ste

@codecov
Copy link

codecov bot commented Aug 12, 2022 •
edited

Codecov Report

Merging #2011 (1bac271) into dev (b5b7be1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev     #2011   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          181       181           
  Lines         2074      2074           
  Branches       544       544           
=========================================
  Hits          2074      2074
Impacted Files Coverage Δ
src/locale/nl.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iamkun
Copy link
Owner

iamkun commented Aug 12, 2022

Thanks

@iamkun iamkun merged commit c93c85e into iamkun:dev Aug 12, 2022
iamkun pushed a commit that referenced this pull request Aug 12, 2022
@semantic-release-bot
chore(release): 1.11.5 [skip ci]
e3777ed 
## [1.11.5](v1.11.4...v1.11.5) (2022-08-12)

### Bug Fixes

* ordinal for nl not working ([#2011](#2011)) ([c93c85e](c93c85e))
* wrong ordinal for french locale ([#2010](#2010)) ([dd192a7](dd192a7))
@iamkun
Copy link
Owner

iamkun commented Aug 12, 2022

🎉 This PR is included in version 1.11.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

BePo65 pushed a commit to BePo65/dayjs that referenced this pull request Oct 10, 2022
@semantic-release-bot @BePo65
chore(release): 1.11.5 [skip ci]
54164cc 
## [1.11.5](iamkun/dayjs@v1.11.4...v1.11.5) (2022-08-12)

### Bug Fixes

* ordinal for nl not working ([iamkun#2011](iamkun#2011)) ([c93c85e](iamkun@c93c85e))
* wrong ordinal for french locale ([iamkun#2010](iamkun#2010)) ([dd192a7](iamkun@dd192a7))
ohsory1324 pushed a commit to ohsory1324/dayjs that referenced this pull request Dec 20, 2023
@semantic-release-bot @ohsory1324
chore(release): 1.11.5 [skip ci]
db9c94c 
## [1.11.5](iamkun/dayjs@v1.11.4...v1.11.5) (2022-08-12)

### Bug Fixes

* ordinal for nl not working ([iamkun#2011](iamkun#2011)) ([c93c85e](iamkun@c93c85e))
* wrong ordinal for french locale ([iamkun#2010](iamkun#2010)) ([dd192a7](iamkun@dd192a7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ctessier @iamkun