fix: wrong ordinal for french locale #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For more context: this is basically a revert of the regression introduced by this PR #1932 in the v1.11.4 |
Codecov Report
@@ Coverage Diff @@
## dev #2010 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 181 181
Lines 2074 2074
Branches 544 544
=========================================
Hits 2074 2074
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thanks, let's get it to revert to the original one |
iamkun
pushed a commit
that referenced
this pull request
Aug 12, 2022
|
🎉 This PR is included in version 1.11.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BePo65
pushed a commit
to BePo65/dayjs
that referenced
this pull request
Oct 10, 2022
## [1.11.5](iamkun/dayjs@v1.11.4...v1.11.5) (2022-08-12) ### Bug Fixes * ordinal for nl not working ([iamkun#2011](iamkun#2011)) ([c93c85e](iamkun@c93c85e)) * wrong ordinal for french locale ([iamkun#2010](iamkun#2010)) ([dd192a7](iamkun@dd192a7))
ohsory1324
pushed a commit
to ohsory1324/dayjs
that referenced
this pull request
Dec 20, 2023
## [1.11.5](iamkun/dayjs@v1.11.4...v1.11.5) (2022-08-12) ### Bug Fixes * ordinal for nl not working ([iamkun#2011](iamkun#2011)) ([c93c85e](iamkun@c93c85e)) * wrong ordinal for french locale ([iamkun#2010](iamkun#2010)) ([dd192a7](iamkun@dd192a7))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In french, when writing dates, there is no ordinal for numbers over 1.
In other contexts, this could be correct, but not for dates.
See for instance on this French website of the government : https://www.service-public.fr/particuliers/actualites