Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SchemaJsonLocater does not support async schema retrieval #6674

Open
RohitPtnkr1996 opened this issue Apr 26, 2024 · 2 comments
Open

SchemaJsonLocater does not support async schema retrieval #6674

RohitPtnkr1996 opened this issue Apr 26, 2024 · 2 comments
Assignees

Comments

@RohitPtnkr1996
Copy link
Contributor

The async function getSchema() within SchemaJsonLocater internally calls getSchemaSync to get a schema.
So, the function is not truly async.

To make the function async, we need to revisit the schema json loading and make that function async (which it currently isn't).
Alternatively, we can create a new schema locater to specifically handle async operations.

@grigasp
Copy link
Member

grigasp commented May 15, 2024

Out of curiosity, why does this have the breaking change label?

@RohitPtnkr1996
Copy link
Contributor Author

I had added it as a possible breaking change until we decide what approach to take.
If we're creating a new async json loader.
Or if we're updating the existing one, in which case the caller that gets the json will need to be async as well.

I'll update the label once I pick this up.

@RohitPtnkr1996 RohitPtnkr1996 self-assigned this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants