Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make accessString a non optional property in QueryPropertyMetaData interface #6548

Open
akshay05n opened this issue Mar 22, 2024 · 0 comments
Open

Make accessString a non optional property in QueryPropertyMetaData interface #6548

akshay05n opened this issue Mar 22, 2024 · 0 comments
Labels
breaking change good first issue Good for newcomers
Milestone
iTwin.js 5.0

Comments

@akshay05n
Copy link
Contributor

If we make it required it could break on the frontend if the server is running a version from before this change. Not sure, but seems possible.

I think our best option is to make this property optional instead of trying to do something 'smart'. For iTwin.js version 5.x we can make this a non-optional property. If we take this route we should create an issue now to make non-optional and tag for 5. x.

Originally posted by @ColinKerr in #6523 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change good first issue Good for newcomers
Projects
None yet
Milestone
iTwin.js 5.0
Development

No branches or pull requests
1 participant
@akshay05n