Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return HTTP 204 "No Content" when "aborted" error is thrown #6475

Open
aruniverse opened this issue Feb 28, 2024 · 0 comments
Open

Return HTTP 204 "No Content" when "aborted" error is thrown #6475

aruniverse opened this issue Feb 28, 2024 · 0 comments
Assignees
@GytisCepk
Labels
breaking change
Milestone
iTwin.js 5.0

Comments

@aruniverse
Copy link
Member

aruniverse commented Feb 28, 2024 •
edited by paulius-valiunas

Most accurate HTTP status code for Aborted errors would be 204, but it would require a breaking change on IModelReadRpcInterface, so for now we treat Aborted as HTTP 400 "Bad Request".

GitHub issue will be open once this PR is merged to switch to 204 for iTwin.js 5.0.

Originally posted by @GytisCepk in #6473 (comment)
@aruniverse aruniverse added this to the iTwin.js 5.0 milestone Feb 28, 2024
@aruniverse aruniverse mentioned this issue Feb 28, 2024
Merged
@GytisCepk GytisCepk changed the title Most accurate HTTP status code for Aborted errors would be 204, but it would require a breaking change on IModelReadRpcInterface, so for now we treat Aborted as HTTP 400 "Bad Request". Return HTTP 204 "No Content" when "aborted" error is thrown Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GytisCepk GytisCepk

Labels
breaking change
Projects
None yet
Milestone
iTwin.js 5.0
Development

No branches or pull requests
2 participants
@aruniverse @GytisCepk