Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when creating a Buffer on Electron 21+ #391

Closed
grigasp opened this issue Aug 3, 2023 · 0 comments · Fixed by #392
Closed

Crash when creating a Buffer on Electron 21+ #391

grigasp opened this issue Aug 3, 2023 · 0 comments · Fixed by #392
Assignees
@grigasp
Labels
bug Something isn't working presentation
Milestone
iTwin.js 4.1

Comments

@grigasp
Copy link
Member

grigasp commented Aug 3, 2023 •
edited

Starting from addon version 4.1.0 (#283), we used Napi::Buffer to expose our large responses to javascript without needing to copy them.

As described in electron/electron#35801 and microsoft/vscode#177338, due to security reasons Electron 21+ stopped supporting creating buffers pointing to external data and now throws a runtime error when doing so.
@grigasp grigasp self-assigned this Aug 3, 2023
@grigasp grigasp added this to the iTwin.js 4.1 milestone Aug 3, 2023
@grigasp grigasp added bug Something isn't working presentation labels Aug 3, 2023
@grigasp grigasp mentioned this issue Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grigasp grigasp

Labels
bug Something isn't working presentation
Projects
None yet
Milestone
iTwin.js 4.1
Development

Successfully merging a pull request may close this issue.

Presentation: Use Buffer::NewOrCopy instead of Buffer::New iTwin/imodel-native
1 participant
@grigasp