Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wbr element to the default transKeepBasicHtmlNodesFor option #1643

Closed
kiddliu opened this issue Jun 3, 2023 · 3 comments
Closed

Add wbr element to the default transKeepBasicHtmlNodesFor option #1643

kiddliu opened this issue Jun 3, 2023 · 3 comments

Comments

@kiddliu
Copy link

kiddliu commented Jun 3, 2023 •
edited

馃殌 Feature Proposal

Add wbr element to the default transKeepBasicHtmlNodesFor option

Motivation

Usually, it may require these 2 solutions when dealing with languages such as German and Russian.

Example

Check https://developer.mozilla.org/en-US/docs/Web/HTML/Element/wbr

<div id="example-paragraphs">
    <p>Fernstra脽enbauprivatfinanzierungsgesetz</p>
    <p>Fernstra脽en<wbr>bau<wbr>privat<wbr>finanzierungs<wbr>gesetz</p>
    <p>Fernstra脽en&shy;bau&shy;privat&shy;finanzierungs&shy;gesetz</p>
</div>
@adrai
Copy link
Member

adrai commented Jun 3, 2023

Would you like to send a Pull Request to address this? Remember to add unit tests.

@kiddliu kiddliu changed the title <wbr> + &shy; Add wbr element to the default transKeepBasicHtmlNodesFor option Jun 3, 2023
@adrai
Copy link
Member

adrai commented Jun 3, 2023

btw: #1560

@kiddliu
Copy link
Author

kiddliu commented Jun 5, 2023

Yes, I did a poor job searching for the related issue and sorry for any inconvenience. Closing the issue...

@kiddliu kiddliu closed this as completed Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adrai @kiddliu