ReactNode should be prefixed with React #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReactNode was incorrectly added in the #1480 without React prefix - breaks tsc compilation, unless skipLibCheck is set.
|
thx, included in v11.16.5 |
|
@adrai The tests are failing because of tslint - TFunctionResult that's imported from i18next is defined as a union of both null and undefined, and that's an error. |
|
maybe @pedrodurek can check this: #1482 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReactNode was incorrectly added in the #1480 without React prefix - breaks tsc compilation, unless skipLibCheck is set.
Checklist
npm run testChecklist (for documentation change)