Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for i18next ^22.0.0 #1965

Closed
belgattitude opened this issue Oct 19, 2022 · 1 comment
Closed

Support for i18next ^22.0.0 #1965

belgattitude opened this issue Oct 19, 2022 · 1 comment

Comments

@belgattitude
Copy link
Contributor

belgattitude commented Oct 19, 2022

馃殌 Feature Proposal

Support for latest i18next major release https://github.com/i18next/i18next/releases/tag/v22.0.0

Motivation

Benefit from upstream typescript improvements.

Proposal

next-i18next has an explicit dependency on ^21.9.1

The easiest is to update to ^22.0.0.

PR: #1966

That avoids situations where 2 instances would be installed (an currently make it hard to debug)

鈹斺攢 nextjs-app@workspace:apps/nextjs-app
   鈹溾攢 i18next@npm:22.0.0 (via npm:22.0.0)
   鈹斺攢 next-i18next@npm:12.1.0 [f054d] (via npm:12.1.0 [f054d])
      鈹斺攢 i18next@npm:21.10.0 (via npm:^21.9.1)

As per i18next changelog there should not be breaking changes between the two versions. So it should be fine

PS: An alternative approach is to move i18next to peerDependencies with a range

  "peerDependencies": {
    "i18next": "^21.9.1 || ^22.0.0"
  }

Installation instructions will need to be updated, ie: yarn install next-i18next i18next... (+ major would clarify the change)

Thanks for the amazing work

@adrai
Copy link
Member

adrai commented Oct 26, 2022

will be released in next major

@adrai adrai closed this as completed Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants