Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix normalize type options #1850

Merged
merged 1 commit into from Oct 19, 2022

Conversation

pedrodurek
Copy link
Member

I forgot to move this last change here, it's more like an improvement than a fix, so we can appropriately test the returnNull and returnEmptyString options.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.157% when pulling 901eaa8 on pedrodurek:fix-normalize-type-options into e599bd5 on i18next:master.

@adrai adrai merged commit 002d9f4 into i18next:master Oct 19, 2022
@adrai
Copy link
Member

adrai commented Oct 19, 2022

Do you want me to create a new patch release for this or is this not necessary?

@pedrodurek
Copy link
Member Author

yeah, it's better to create a patch release, sorry @adrai ❤️

@adrai
Copy link
Member

adrai commented Oct 19, 2022

no problem, v22.0.1 has just been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants