-
-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add store events to typings #1451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add appropriate usage tests to the test/typescript
directory to prevent regressions.
Check, please |
index.d.ts
Outdated
/** | ||
* Gets fired when resources got added | ||
*/ | ||
on(event: 'added', callback: (lng: string, ns: string) => void): void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I just noticed, why not combine these as:
- on(event: 'added', callback: (lng: string, ns: string) => void): void;
- on(event: 'removed', callback: (lng: string, ns: string) => void): void;
+ on(event: 'removed' | 'added', callback: (lng: string, ns: string) => void): void;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed
@jamuhl this can be a patch release |
was published in i18next@19.4.5 thanks to all 👍 |
Fix typings for #1450