Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support .ts, .json and .yaml config #673

Merged
merged 3 commits into from Nov 11, 2022
Merged

support .ts, .json and .yaml config #673

merged 3 commits into from Nov 11, 2022

Conversation

guoyunhe
Copy link
Contributor

@guoyunhe guoyunhe commented Nov 6, 2022

Why am I submitting this PR

support .ts, .json and .yaml config

Does it fix an existing ticket?

No

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • tests are included and pass: yarn test (see details here)
  • documentation is changed or added

@socket-security
Copy link

socket-security bot commented Nov 6, 2022

Socket Security Pull Request Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
esbuild@0.15.13 (added) postinstall package.json
Pull request report summary
Issue Status
Install scripts ⚠️ 1 issue
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

  • @SocketSecurity ignore esbuild@0.15.13

Powered by socket.dev

@guoyunhe
Copy link
Contributor Author

guoyunhe commented Nov 6, 2022

Here is one unit test failed. But I believe it is not related to my changes.

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2022

Codecov Report

Base: 95.39% // Head: 93.84% // Decreases project coverage by -1.55% ⚠️

Coverage data is based on head (1e30eb2) compared to base (3450253).
Patch coverage: 28.20% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
- Coverage   95.39%   93.84%   -1.56%     
==========================================
  Files          11       11              
  Lines        1650     1689      +39     
==========================================
+ Hits         1574     1585      +11     
- Misses         76      104      +28     
Impacted Files Coverage Δ
src/helpers.js 91.54% <28.20%> (-8.46%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@karellm karellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Can you remove the console.log ?

src/helpers.js Outdated
}

async function tsConfigLoader(filepath) {
console.log(filepath)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Console.log :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@karellm karellm merged commit 7d852be into i18next:master Nov 11, 2022
@karellm
Copy link
Member

karellm commented Nov 11, 2022

Published as 7.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants