Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: do not fail on JSX spread attribute in Trans component #637

Merged
merged 1 commit into from Oct 5, 2022

Conversation

dimazollo
Copy link

@dimazollo dimazollo commented Oct 3, 2022

Why am I submitting this PR

#367

Does it fix an existing ticket?

Yes, it fixes #367

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • tests are included and pass: yarn test (see details here)
  • documentation is changed or added

@codecov-commenter
Copy link

Codecov Report

Base: 95.34% // Head: 95.36% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (63fcf74) compared to base (67cf845).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
+ Coverage   95.34%   95.36%   +0.02%     
==========================================
  Files          11       11              
  Lines        1633     1641       +8     
==========================================
+ Hits         1557     1565       +8     
  Misses         76       76              
Impacted Files Coverage Δ
src/lexers/jsx-lexer.js 98.12% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@karellm karellm merged commit b222944 into i18next:master Oct 5, 2022
@karellm
Copy link
Member

karellm commented Oct 5, 2022

Deployed as part of 6.6.0. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'text' of undefined in jsx-lexer
3 participants