Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TypeScript typecasts #604

Merged
merged 1 commit into from Oct 5, 2022
Merged

Support TypeScript typecasts #604

merged 1 commit into from Oct 5, 2022

Conversation

joshkel
Copy link
Contributor

@joshkel joshkel commented Jun 14, 2022

Why am I submitting this PR

Add support for TypeScript typecasts within JSX expressions.

Does it fix an existing ticket?

Yes - #603

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • tests are included and pass: yarn test (see details here)
  • documentation is changed or added

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #604 (dbe5156) into master (67cf845) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
+ Coverage   95.34%   95.36%   +0.01%     
==========================================
  Files          11       11              
  Lines        1633     1640       +7     
==========================================
+ Hits         1557     1564       +7     
  Misses         76       76              
Impacted Files Coverage Δ
src/lexers/jsx-lexer.js 98.11% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67cf845...dbe5156. Read the comment docs.

@karellm karellm merged commit dfaf626 into i18next:master Oct 5, 2022
@joshkel joshkel deleted the jsx-as branch October 5, 2022 13:29
@karellm
Copy link
Member

karellm commented Oct 5, 2022

Deployed as part of 6.6.0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants