Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export the backend options type #105

Merged
merged 2 commits into from Dec 10, 2022
Merged

Export the backend options type #105

merged 2 commits into from Dec 10, 2022

Conversation

2Pacalypse-
Copy link
Contributor

Also, stop overriding the CustomPluginOptions in the i18next module since that conflicts with other backends.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@2Pacalypse-
Export the backend options type
285406f 
Also, stop overriding the CustomPluginOptions in the i18next module
since that conflicts with other backends.
@2Pacalypse-
Copy link
Contributor Author

Ref: #103

@2Pacalypse- 2Pacalypse- mentioned this pull request Dec 10, 2022
Closed
@adrai
Copy link
Member

adrai commented Dec 10, 2022

Can you maybe also add a piece in the readme for the new TS usage also here?

@adrai adrai merged commit 0085ebb into i18next:master Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@2Pacalypse- @adrai