Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't assign I18NexFsBackend to NewableModule<BackendModule> #33

Merged
merged 1 commit into from Nov 25, 2022
Merged

Can't assign I18NexFsBackend to NewableModule<BackendModule> #33

merged 1 commit into from Nov 25, 2022

Conversation

miniplus
Copy link
Contributor

Solves #32

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@adrai
Copy link
Member

adrai commented Nov 25, 2022

@pedrodurek ok for you?

@adrai
Copy link
Member

adrai commented Nov 25, 2022

will merge now, but would love if @pedrodurek could check for the general types usage in collaboration with the i18next plugins

@adrai adrai merged commit 802e23a into i18next:master Nov 25, 2022
@adrai
Copy link
Member

adrai commented Nov 25, 2022

included in v2.0.1

@pedrodurek
Copy link
Member

Sorry @adrai, I wasn't close to my computer in the last couple of days, it looks great to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants