Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge material-ui-sass project, so both less/sass versions are usable out of the box #316

Closed
msikma opened this issue Feb 7, 2015 · 3 comments · Fixed by #588 · 4 remaining pull requests
Closed

Merge material-ui-sass project, so both less/sass versions are usable out of the box #316

msikma opened this issue Feb 7, 2015 · 3 comments · Fixed by #588 · 4 remaining pull requests
Labels
support: docs-feedback Feedback from documentation page

Comments

@msikma
Copy link

msikma commented Feb 7, 2015

@gpbl did a huge amount of good work on the material-ui-sass port. I think it would be a good idea to incorporate his work into the main project. This would have several advantages:

  • Makes it easier for end users to choose whether to use sass or less—no need for an extra dependency;
  • Whenever the less changes an issue can easily be raised to update the sass versions (rather than going to another project and raising it there);
  • Feature parity between the less/sass versions can be maintained more efficiently.

At the moment, the Sass port works with version ^0.5.0. I'm the author of my own Sass framework and I'd be willing to help out in bringing it up to the latest version and keeping it up-to-date once it's there.
@gpbl
Copy link
Contributor

gpbl commented Feb 7, 2015

👍

Maintaining the port is not as fast as it should, since I wait for the official releases, then go with the diff. If someone adds a pull request to the the sass version is even harder to spot the differences.

I'm a bit slow updating the port to the last release (just moved to a new place :-)) but I should be finished with it soon.

@msikma
Copy link
Author

msikma commented Feb 8, 2015

Nice to hear you've been working on 0.6.0 support. The project is moving pretty fast. There's a whole month of changes between 0.5.0 and 0.6.1. Although some of it also seems to be trivial changes, such as changing the indentation.

I think having the two codebases side by side would be beneficial to the Sass port for sure.

@hai-cea
Copy link
Member

hai-cea commented Feb 8, 2015

@msikma and @gpbl - You may want to keep an eye on this issue - #30 (comment)

If we're able to accomplish this, then less/sass compilation will no longer be needed.

@msikma msikma mentioned this issue Feb 9, 2015
Closed
This was referenced Apr 27, 2015
Merged
Merged
@akashmitra akashmitra mentioned this issue Nov 4, 2022
Open
@snyk-bot snyk-bot mentioned this issue Nov 5, 2022
Open
@hzhz hzhz mentioned this issue Nov 5, 2022
Open
@zhaleTaheri zhaleTaheri mentioned this issue Nov 5, 2022
Open
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@akashmitra akashmitra mentioned this issue Dec 25, 2022
Open
@maniator maniator mentioned this issue Dec 26, 2022
Open
@hzhz hzhz mentioned this issue Dec 26, 2022
Open
@zhaleTaheri zhaleTaheri mentioned this issue Dec 26, 2022
Open
@zannager zannager added support: docs-feedback Feedback from documentation page and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
@zhaleTaheri zhaleTaheri mentioned this issue Jun 23, 2023
Open
@hzhz hzhz mentioned this issue Jun 24, 2023
Open
@akashmitra akashmitra mentioned this issue Jun 24, 2023
Open
@maniator maniator mentioned this issue Jun 24, 2023
Open
@hzhz hzhz mentioned this issue Nov 30, 2023
Open
@hzhz hzhz mentioned this issue Feb 2, 2024
Open
@maniator maniator mentioned this issue Feb 2, 2024
Open
@akashmitra akashmitra mentioned this issue Feb 2, 2024
Open
@zhaleTaheri zhaleTaheri mentioned this issue Feb 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
support: docs-feedback Feedback from documentation page
Projects
None yet
Milestone
No milestone
5 participants
@gpbl @msikma @hai-cea @oliviertassinari @zannager