Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make form submissions open in a new tab and leave Via #182

Open
seanh opened this issue May 20, 2021 · 0 comments
Open

Make form submissions open in a new tab and leave Via #182

seanh opened this issue May 20, 2021 · 0 comments

Comments

@seanh
Copy link
Collaborator

seanh commented May 20, 2021

When a user clicks on a link in Via it opens the link target in a new tab that is not proxied by Via: #9

But when the navigation is triggered by a form submission this still navigates the original tab and does not leave Via. For example Google and Bing's search forms do this kind of navigation.

We need to intercept these form submissions and make them open in a new, non-proxied tab like normal links do.

A JavaScript one-liner for programmatic link clicks was given in this thread, and it was suggested that something similar could work for form submissions:

https://hypothes-is.slack.com/archives/C1M8NH76X/p1621418996025700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant