Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When loading pending updates, consider scrolling to the "closest" one, not the latest one #6340

Open
acelaya opened this issue Apr 16, 2024 · 2 comments

Comments

@acelaya
Copy link
Contributor

acelaya commented Apr 16, 2024

As part of #6255, we implemented some logic to scroll the sidebar to display the most recent one of the new or updated annotations (see #6338 and #6337).

However, we have considered checking which is closest to the active viewport (if none of them are already inside of it) and scrolling to that one, to reduce viewport disruption as much as possible.

@robertknight
Copy link
Member

robertknight commented Apr 16, 2024

I'm not sure about this. Scrolling to the newest or oldest update seems like it would feel more predictable to me than scrolling to whichever happens to be nearest in the viewport - which could be at an arbitrary distance from the current viewport position.

@acelaya
Copy link
Contributor Author

acelaya commented Apr 16, 2024

I'm not sure about this. Scrolling to the newest or oldest update seems like it would feel more predictable to me than scrolling to whichever happens to be nearest in the viewport - which could be at an arbitrary distance from the current viewport position.

Yep, I tend to agree with this. After implementing it date-based, it does feel like the right approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants